Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changing some key translations - Setup Wizard #30462

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Conversation

tiagoevanp
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

NBJ-373

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023

⚠️ No Changeset found

Latest commit: 38cb43d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tiagoevanp tiagoevanp added this to the 6.5.0 milestone Sep 21, 2023
@tiagoevanp tiagoevanp marked this pull request as ready for review September 21, 2023 19:56
@tiagoevanp tiagoevanp requested a review from a team September 21, 2023 19:56
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #30462 (38cb43d) into develop (9261368) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30462      +/-   ##
===========================================
- Coverage    50.23%   50.19%   -0.05%     
===========================================
  Files          780      774       -6     
  Lines        14476    14455      -21     
  Branches      2617     2613       -4     
===========================================
- Hits          7272     7255      -17     
+ Misses        6809     6794      -15     
- Partials       395      406      +11     
Flag Coverage Δ
e2e 48.55% <ø> (-0.05%) ⬇️
unit 60.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp changed the title feat: Changing some key translations in favor of NBJ - Setup Wizard feat: Changing some key translations - Setup Wizard Sep 22, 2023
@ggazzo ggazzo changed the title feat: Changing some key translations - Setup Wizard chore: Changing some key translations - Setup Wizard Sep 22, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 27, 2023
@kodiakhq kodiakhq bot merged commit 7061b67 into develop Sep 27, 2023
@kodiakhq kodiakhq bot deleted the nbj/setup-wizard branch September 27, 2023 05:28
gabriellsh added a commit that referenced this pull request Sep 27, 2023
…ove/iframeLogin

* 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits)
  feat: New records page analytics tab (#30373)
  chore: Changing some key translations - Setup Wizard (#30462)
  feat: use isolated-vm to run integration scripts (#30229)
  fix: do not broadcast events from the local node to the local service (duplicated event) (#30446)
  fix: Microsoft autotranslate not working (#30390)
  chore: `ResetPasswordPage` a11y improvements (#30479)
  chore: `ResetPasswordForm` a11y improvements (#30476)
  chore: Move bad words filter callback to service (#30241)
  fix: Message disappears from room after deletion even if "Show Deleted Status" is enabled (#30452)
  chore: add tooltip to mentions (#30445)
  chore: bump mongo deps (#30450)
  ci: patch mongo type definitions (#30449)
  chore: cache incremental ts check (#30447)
  Release 6.4.0-rc.4
  Release 6.4.0-rc.3
  chore: update meteor 2.13.0 (#29989)
  chore: Assertion accuracy on registration test (#30440)
  ci: Add step to notify external services about a new release after Docker image publish (#30436)
  regression: close button not working on contact history (#30432)
  regression: custom fields not showing in current chats (#30428)
  ...
gabriellsh added a commit that referenced this pull request Sep 28, 2023
…/mentionBot

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: move Omnichannel toolbox section from sidebar room list (#30502)
  fix: RTL lang crashes Moderation Console  (#30393)
  feat: New records page analytics tab (#30373)
  chore: Changing some key translations - Setup Wizard (#30462)
  feat: use isolated-vm to run integration scripts (#30229)
  fix: do not broadcast events from the local node to the local service (duplicated event) (#30446)
  fix: Microsoft autotranslate not working (#30390)
  chore: `ResetPasswordPage` a11y improvements (#30479)
  chore: `ResetPasswordForm` a11y improvements (#30476)
  chore: Move bad words filter callback to service (#30241)
  fix: Message disappears from room after deletion even if "Show Deleted Status" is enabled (#30452)
  chore: add tooltip to mentions (#30445)
ggazzo added a commit that referenced this pull request Sep 28, 2023
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants